This repository was archived by the owner on May 8, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6
CIRRUS_CLONE_DIR #130
Closed
CIRRUS_CLONE_DIR #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
You can greatly simplify the logic by re-using it from the #129. I've ran your tests with it and found the following differences:
|
edigaryev
reviewed
Apr 19, 2021
Err: this allows a user to both clone into some non-standard directory and run some |
edigaryev
reviewed
Apr 19, 2021
internal/executor/executor.go
Outdated
result["CIRRUS_CLONE_DIR"] = executor.preCreatedWorkingDir | ||
hasCloneDir = true | ||
// Need to override working dir too | ||
if hasWorkingDir && !strings.Contains(result["CIRRUS_WORKING_DIR"], "CIRRUS_CLONE_DIR") { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if the $CIRRUS_CLONE_DIR
variable occurrence in the middle of CIRRUS_WORKING_DIR
should be considered as the CIRRUS_WORKING_DIR
won't be rooted in CIRRUS_CLONE_DIR
this way.
See #129 for a more strict check.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.